transfer class #310
transfer class #310
Conversation
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)
backend/api/serializers/klass.py line 35 at r1 (raw file):
def validate_teacher(self, value: Teacher): user = self.request.school_teacher_user if value.school_id != user.teacher.school_id:
Shall we do just school instead of school_id?
backend/api/tests/views/test_klass.py line 105 at r1 (raw file):
def test_create__other(self): """ Teacher can create a class with another teacher as the class owner.
Admin teacher
|
Previously, faucomte97 (Florian Aucomte) wrote…
Generally speaking, it's more efficient to compare 2 related objects by their iIDs as you avoid fetching the related objects from the db. Also it does the same equality comparison under the hood anyway so it's logically the same check. This will not call the db to fetch the school objects and check the ids value.school_id != user.teacher.school_idThis call the db to fetch the 2 school objects (so 2 db calls) and then check the ids (under the hood it's doing value.school != user.teacher.school |
feedback
There was a problem hiding this comment.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @faucomte97)
backend/api/tests/views/test_klass.py line 105 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Admin teacher
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is